fix(tools): fabric AIO image log access in CI #643 #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is meant to make it much easier to debug issues with the Fabric 2.x AIO container image in the future when new bugs (inevitably) arise. Meaning that the logs of the child processess such as the fabric network creator script or the docker daemon will all be piped through to the logs of the container itself instead of just being dumped into log files under /var/log/... which has the upside of not having to shell into the container when something goes wrong and one wishes to debug what happened. Instead the logs of the container will show all the information right away. In addition to the above change a flag was added to the FabricTestLedger class' constructor options so that one can tell the class to dump the continer's log stream straight onto it's own logger meaning that now if you are debugging a test case you will be able to see all the logs that are being output straight in the logs of the test case itself. This can be very spammy at times, hence the flag that can be used to turn it on or off depending on what is needed more. One more small change that we made to help debugging: The supervisord config file now specifies the loglevel of supervisord as debug instead of info. Fixes hyperledger-cacti#643 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added
bug
petermetz
requested review from
kikoncuo,
sfuji822,
jonathan-m-hamilton and
takeutak
This was referenced Mar 10, 2021
takeutak
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is meant to make it much easier to debug
issues with the Fabric 2.x AIO container image in the
future when new bugs (inevitably) arise.
Meaning that the logs of the child processess such as
the fabric network creator script or the docker daemon will
all be piped through to the logs of the container itself
instead of just being dumped into log files under
/var/log/... which has the upside of not having to
shell into the container when something goes wrong
and one wishes to debug what happened. Instead the
logs of the container will show all the information
right away.
In addition to the above change a flag was added to
the FabricTestLedger class' constructor options so
that one can tell the class to dump the continer's
log stream straight onto it's own logger meaning
that now if you are debugging a test case you will
be able to see all the logs that are being output
straight in the logs of the test case itself.
This can be very spammy at times, hence the flag
that can be used to turn it on or off depending on
what is needed more.
One more small change that we made to help debugging:
The supervisord config file now specifies the loglevel
of supervisord as debug instead of info.
Fixes #643
Signed-off-by: Peter Somogyvari [email protected]